linux-kernel - Re: [PATCH 1/2] iommu/amd: Fix compiler warning in copy_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170819011600.GC20615@x1>
Date:   Sat, 19 Aug 2017 09:16:00 +0800
From:   Baoquan He <bhe@...hat.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
        Joerg Roedel <jroedel@...e.de>
Subject: Re: [PATCH 1/2] iommu/amd: Fix compiler warning in
 copy_device_table()

On 08/19/17 at 12:40am, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@...e.de>
> 
> This was reported by the kbuild bot. The condition in which
> entry would be used uninitialized can not happen, because
> when there is no iommu this function would never be called.
> But its no fast-path, so fix the warning anyway.
> 
> Reported-by: kbuild test robot
> Signed-off-by: Joerg Roedel <jroedel@...e.de>

Thanks for fixing these code bugs, Joerg.

Ack the series!

Acked-by: Baoquan He <bhe@...hat.com>

> ---
>  drivers/iommu/amd_iommu_init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index c7d0325..f2023cd 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -854,7 +854,7 @@ static int get_dev_entry_bit(u16 devid, u8 bit)
>  
>  static bool copy_device_table(void)
>  {
> -	u64 int_ctl, int_tab_len, entry, last_entry = 0;
> +	u64 int_ctl, int_tab_len, entry = 0, last_entry = 0;
>  	struct dev_table_entry *old_devtb = NULL;
>  	u32 lo, hi, devid, old_devtb_size;
>  	phys_addr_t old_devtb_phys;
> -- 
> 2.7.4
>