linux-kernel - Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170819092940.62513d5c@gmail.com>
Date:   Sat, 19 Aug 2017 09:29:40 +0300
From:   Maksim Salau <maksim.salau@...il.com>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        akpm@...ux-foundation.org,
        "Alfredo Rafael Vicente Boix" <alviboi@...il.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on
 stack

On Fri, 18 Aug 2017 14:13:20 +0100
Ben Hutchings <ben@...adent.org.uk> wrote:

> 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Maksim Salau <maksim.salau@...il.com>
> 
> commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream.
> 
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().

Hi Ben,

The change has a memory leak, which is fixed by the commit
0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3
If the commit is not in your queue, please add it.

Thanks,
Maksim.