linux-kernel - [PATCH v2] phy: qcom-usb-hsic: Fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 20 Aug 2017 12:16:23 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     kishon@...com, vivek.gautam@...eaurora.org,
        stephen.boyd@...aro.org, jh80.chung@...sung.com
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: [PATCH v2] phy: qcom-usb-hsic: Fix error handling

According to error handling in this function, it is likely that going to
'err_ulpi' was expected here.

Fixes: 	605b8652f7f0 ("phy: Add support for Qualcomm's USB HSIC phy")
Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Reviewed-by: Stephen Boyd <stephen.boyd@...aro.org>
---
v2: rebase after commit 0b56e9a7e835 which has moved from
       drivers/phy/phy-qcom-usb-hsic.c
    to
       drivers/phy/qualcomm/phy-qcom-usb-hsic.c

Reviewed-by tag can be found at https://lkml.org/lkml/2017/2/20/48
---
 drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
index c110563a73cb..00926df4bc5b 100644
--- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
+++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
@@ -57,8 +57,10 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy)
 
 	/* Configure pins for HSIC functionality */
 	pins_default = pinctrl_lookup_state(uphy->pctl, PINCTRL_STATE_DEFAULT);
-	if (IS_ERR(pins_default))
-		return PTR_ERR(pins_default);
+	if (IS_ERR(pins_default)) {
+		ret = PTR_ERR(pins_default);
+		goto err_ulpi;
+	}
 
 	ret = pinctrl_select_state(uphy->pctl, pins_default);
 	if (ret)
-- 
2.11.0