linux-kernel - Re: [PATCH 031/102] iio: adc: rockchip_saradc: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 20 Aug 2017 12:09:02 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     linux-kernel@...r.kernel.org, Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Heiko Stuebner <heiko@...ech.de>, linux-iio@...r.kernel.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 031/102] iio: adc: rockchip_saradc: explicitly request
 exclusive reset control

On Wed, 19 Jul 2017 17:25:35 +0200
Philipp Zabel <p.zabel@...gutronix.de> wrote:

> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
> reset lines") started to transition the reset control request API calls
> to explicitly state whether the driver needs exclusive or shared reset
> control behavior. Convert all drivers requesting exclusive resets to the
> explicit API call so the temporary transition helpers can be removed.
> 
> No functional changes.
> 
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Hartmut Knaack <knaack.h@....de>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Peter Meerwald-Stadler <pmeerw@...erw.net>
> Cc: Heiko Stuebner <heiko@...ech.de>
> Cc: linux-iio@...r.kernel.org
> Cc: linux-rockchip@...ts.infradead.org
> Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/iio/adc/rockchip_saradc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index ae6d3324f5183..1d9300ba07c00 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -235,7 +235,8 @@ static int rockchip_saradc_probe(struct platform_device *pdev)
>  	 * The reset should be an optional property, as it should work
>  	 * with old devicetrees as well
>  	 */
> -	info->reset = devm_reset_control_get(&pdev->dev, "saradc-apb");
> +	info->reset = devm_reset_control_get_exclusive(&pdev->dev,
> +						       "saradc-apb");
>  	if (IS_ERR(info->reset)) {
>  		ret = PTR_ERR(info->reset);
>  		if (ret != -ENOENT)