linux-kernel - Re: [PATCH] input/keyboard: fix platform_no_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170820162841.GA1176@dtor-ws>
Date:   Sun, 20 Aug 2017 09:28:41 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Takashi Iwai <tiwai@...e.de>, alsa-devel@...a-project.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...org
Subject: Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings

On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
> 
>  dc_ti_pwrbtn.c |    1 -

Hm, this driver is neither in my tree nor in next; where is it coming
from?

>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
>  static struct platform_driver dc_ti_pwrbtn_driver = {
>  	.driver = {
>  		.name = DRIVER_NAME,
> -		.owner = THIS_MODULE,
>  	},
>  	.probe	= dc_ti_pwrbtn_probe,
>  };

-- 
Dmitry