linux-kernel - Re: [PATCH v7 02/15] lib: Add shared copies of some GCC library routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <mhng-7ffaa0f4-dc5d-42d0-a927-83262fecee02@palmer-si-x1c4>
Date:   Sun, 20 Aug 2017 12:54:05 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     andriy.shevchenko@...ux.intel.com
CC:     peterz@...radead.org, tglx@...utronix.de, jason@...edaemon.net,
        marc.zyngier@....com, Arnd Bergmann <arnd@...db.de>,
        yamada.masahiro@...ionext.com, mmarek@...e.com, albert@...ive.com,
        will.deacon@....com, boqun.feng@...il.com, oleg@...hat.com,
        mingo@...hat.com, daniel.lezcano@...aro.org,
        gregkh@...uxfoundation.org, jslaby@...e.com, davem@...emloft.net,
        mchehab@...nel.org, hverkuil@...all.nl, rdunlap@...radead.org,
        viro@...iv.linux.org.uk, mhiramat@...nel.org, fweisbec@...il.com,
        mcgrof@...nel.org, dledford@...hat.com, bart.vanassche@...disk.com,
        sstabellini@...nel.org, mpe@...erman.id.au,
        rmk+kernel@...linux.org.uk, paul.gortmaker@...driver.com,
        nicolas.dichtel@...nd.com, linux@...ck-us.net,
        heiko.carstens@...ibm.com, schwidefsky@...ibm.com,
        geert@...ux-m68k.org, akpm@...ux-foundation.org, jiri@...lanox.com,
        vgupta@...opsys.com, airlied@...hat.com, jk@...abs.org,
        chris@...is-wilson.co.uk, Jason@...c4.com,
        paulmck@...ux.vnet.ibm.com, ncardwell@...gle.com,
        linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        patches@...ups.riscv.org
Subject:     Re: [PATCH v7 02/15] lib: Add shared copies of some GCC library routines

On Tue, 01 Aug 2017 06:06:20 PDT (-0700), andriy.shevchenko@...ux.intel.com wrote:
> On Mon, 2017-07-31 at 17:59 -0700, Palmer Dabbelt wrote:
>> Many ports (m32r, microblaze, mips, parisc, score, and sparc) use
>> functionally identical copies of various GCC library routine files,
>> which came up as we were submitting the RISC-V port (which also uses
>> some of these).
>>
>> This patch adds a new copy of these library routine files, which are
>> functionally identical to the various other copies.  These are
>> availiable via Kconfig as CONFIG_GENERIC_$ROUTINE, which currently
>> isn't
>> used anywhere.
>>
>
>
>> Signed-off-by: Palmer Dabbelt <palmer@...belt.com>
>
>> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
>> Signed-off-by: Palmer Dabbelt <palmer@...belt.com>
>
> That's why we are putting tags before own SoB line(s)

OK, sorry about that -- I'll fix it for our v8 patch set.

> In two cases in the patch you have
>
> +
> +
>
> for no reason. I think you may remove second empty line.

Makes sense.  I'll squash this into the next patch set.

diff --git a/include/lib/libgcc.h b/include/lib/libgcc.h
index a5397e34e005..32e1e0f4b2d0 100644
--- a/include/lib/libgcc.h
+++ b/include/lib/libgcc.h
@@ -16,7 +16,6 @@
  * to the Free Software Foundation, Inc.
  */

-
 #ifndef __LIB_LIBGCC_H
 #define __LIB_LIBGCC_H

diff --git a/lib/ashldi3.c b/lib/ashldi3.c
index ff4ec63d2ab6..1b6087db95a5 100644
--- a/lib/ashldi3.c
+++ b/lib/ashldi3.c
@@ -14,7 +14,6 @@
  * to the Free Software Foundation, Inc.
  */

-
 #include <linux/export.h>

 #include <lib/libgcc.h>