linux-kernel - Re: [RFC 2/3] rtc: Add Realtek RTD1295

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b607c23-92f9-a466-fd1c-92189177f174@suse.de>
Date:   Sun, 20 Aug 2017 23:12:05 +0200
From:   Andreas Färber <afaerber@...e.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        ????????? <jiang.liqin@...iatech.com>,
        linux-kernel@...r.kernel.org, Roc He <hepeng@...oo.tv>
Subject: Re: [RFC 2/3] rtc: Add Realtek RTD1295

Am 20.08.2017 um 17:40 schrieb Andrew Lunn:
>> +static void rtd119x_rtc_set_enabled(struct device *dev, bool enable)
>> +{
>> +	struct rtd119x_rtc *data = dev_get_drvdata(dev);
>> +	u32 val;
>> +
>> +	val = readl_relaxed(data->base + RTD_RTCEN);
>> +	dev_info(dev, "%s: rtcen = 0x%08x\n", __func__, val);
> 
> dev_dbg()?
> 
>> +static int rtd119x_rtc_open(struct device *dev)
>> +{
>> +	struct rtd119x_rtc *data = dev_get_drvdata(dev);
>> +	u32 val;
>> +	int ret;
>> +
>> +	ret = clk_prepare_enable(data->clk);
>> +	if (ret)
>> +		return ret;
>> +
>> +	val = readl_relaxed(data->base + RTD_RTCACR);
>> +	dev_info(dev, "rtcacr = 0x%08x\n", val);
> 
> dev_dbg()?

Yeah, either that or dropping them altogether.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)