linux-kernel - Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB3L5ozBebeEJ4PiXHLYTjdK3H97fGA_6coZX3dSEiafGZ74-g@mail.gmail.com>
Date:   Sun, 20 Aug 2017 06:36:02 +0530
From:   Srishti Sharma <srishtishar@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     ruxandra.radulescu@....com, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple
 assignments should be avoided.

On Sun, Aug 20, 2017 at 5:37 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Sun, Aug 20, 2017 at 04:01:25AM +0530, Srishti Sharma wrote:
>> Fixed a check reported by checkpatch.pl to avoid multiple assignments in a single statement.
>
> Always wrap your changelog text at 72 columns please.
>
>>
>> Signed-off-by: Srishti Sharma <srishtishar@...il.com>
>> ---
>>  drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
>> index 26017fe..75e3366 100644
>> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
>> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
>> @@ -1636,7 +1636,8 @@ static void set_fq_affinity(struct dpaa2_eth_priv *priv)
>>        * This may well change at runtime, either through irqbalance or
>>        * through direct user intervention.
>>        */
>> -     rx_cpu = txc_cpu = cpumask_first(&priv->dpio_cpumask);
>> +     rx_cpu = cpumask_first(&priv->dpio_cpumask);
>> +     txc_cpu = cpumask_first(&priv->dpio_cpumask);
>
> The original code is nicer, as you don't have to do the computation
> twice.
>
> thanks,
>
> greg k-h

Okay, Thanks :)

Regards,
Srishti