linux-kernel - Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170821074936.ae2sw2ncvoaxsq3w@dell>
Date:   Mon, 21 Aug 2017 08:49:36 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     stwiss.opensource@...semi.com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Revert "mfd: da9061: Fix to remove BBAT_CONT
 register from chip model"

On Tue, 15 Aug 2017, Lee Jones wrote:

> This patch was applied to the MFD twice, causing unwanted behavour.
> 
> This reverts commit b77eb79acca3203883e8d8dbc7f2b842def1bff8.
> 
> Fixes: b77eb79acca3 ("mfd: da9061: Fix to remove BBAT_CONT register from chip model")
> Reported-by: Steve Twiss <stwiss.opensource@...semi.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mfd/da9062-core.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Steve, It would be good to obtain a {Reviewed|Acked}-by from you
before applying.

> diff --git a/drivers/mfd/da9062-core.c b/drivers/mfd/da9062-core.c
> index fbe0f245ce8e..fe1811523e4a 100644
> --- a/drivers/mfd/da9062-core.c
> +++ b/drivers/mfd/da9062-core.c
> @@ -645,6 +645,9 @@ static const struct regmap_range da9062_aa_readable_ranges[] = {
>  		.range_min = DA9062AA_VLDO1_B,
>  		.range_max = DA9062AA_VLDO4_B,
>  	}, {
> +		.range_min = DA9062AA_BBAT_CONT,
> +		.range_max = DA9062AA_BBAT_CONT,
> +	}, {
>  		.range_min = DA9062AA_INTERFACE,
>  		.range_max = DA9062AA_CONFIG_E,
>  	}, {
> @@ -721,6 +724,9 @@ static const struct regmap_range da9062_aa_writeable_ranges[] = {
>  		.range_min = DA9062AA_VLDO1_B,
>  		.range_max = DA9062AA_VLDO4_B,
>  	}, {
> +		.range_min = DA9062AA_BBAT_CONT,
> +		.range_max = DA9062AA_BBAT_CONT,
> +	}, {
>  		.range_min = DA9062AA_GP_ID_0,
>  		.range_max = DA9062AA_GP_ID_19,
>  	},

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog