| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Aug 2017 01:08:16 -0700
From: Banajit Goswami <bgoswami@...eaurora.org>
To: Peng Donglin <dolinux.peng@...il.com>
Cc: lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
tiwai@...e.com, plai@...eaurora.org, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH 08/12] ASoC: qcom: Remove useless function
call
On Sun, Aug 20, 2017 at 01:43:57PM +0800, Peng Donglin wrote:
> The function platform_set_drvdata(pdev, data) copies the value of
> the variable data to pdev->dev.driver_data,but when calling
> snd_soc_register_card,the function dev_set_drvdata(card->dev, card)
> will override it, so i think that the former copy operation is
> useless and can be removed.
>
> Signed-off-by: Peng Donglin <dolinux.peng@...il.com>
Acked-by: Banajit Goswami <bgoswami@...eaurora.org>
> ---
> sound/soc/qcom/apq8016_sbc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c
> index d084d74..5292591 100644
> --- a/sound/soc/qcom/apq8016_sbc.c
> +++ b/sound/soc/qcom/apq8016_sbc.c
> @@ -191,7 +191,6 @@ static int apq8016_sbc_platform_probe(struct platform_device *pdev)
> if (IS_ERR(data->spkr_iomux))
> return PTR_ERR(data->spkr_iomux);
>
> - platform_set_drvdata(pdev, data);
> snd_soc_card_set_drvdata(card, data);
>
> return devm_snd_soc_register_card(&pdev->dev, card);
> --
> 1.9.1
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Powered by blists - more mailing lists