linux-kernel - Re: [rfc patch] sched/topology: fix domain reconstruction memory leakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170821081615.cpjmas4x5p7pcrbh@hirez.programming.kicks-ass.net>
Date:   Mon, 21 Aug 2017 10:16:15 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Mike Galbraith <efault@....de>
Cc:     Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [rfc patch] sched/topology: fix domain reconstruction memory
 leakage

On Sat, Aug 19, 2017 at 08:10:49AM +0200, Mike Galbraith wrote:
> Greetings,
> 
> While beating on cpu hotplug with the shiny new topology fixes
> backported, my memory poor 8 socket box fairly quickly leaked itself to
> death, 0c0e776a9b0f being the culprit.  With the below applied, box
> took a severe beating overnight without a whimper.
> 
> I'm wondering (ergo rfc) if free_sched_groups() shouldn't be renamed to
> put_sched_groups() instead, with overlapping domains taking a group
> reference reference as well so they can put both sg/sgc rather than put
> one free the other.  Those places that want an explicit free can pass
> free to only explicitly free sg (or use two functions).  Minimalist
> approach works (minus signs, yay), but could perhaps use some "pretty".
> 
> sched/topology: fix domain reconstruction memory leakage

I was sitting on this one:

  https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/commit/?h=sched/core&id=c63d18dd6ea59eec5cba857835f788943ff9f0d5

is that the same?