linux-kernel - [tip:efi/core] firmware/efi: Constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-3ad6bd7c0a1c49a78d00001cfda3d474c23bc354@git.kernel.org>
Date:   Mon, 21 Aug 2017 02:20:07 -0700
From:   tip-bot for Arvind Yadav <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     matt@...eblueprint.co.uk, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, hpa@...or.com, peterz@...radead.org,
        mingo@...nel.org, ard.biesheuvel@...aro.org,
        torvalds@...ux-foundation.org, arvind.yadav.cs@...il.com
Subject: [tip:efi/core] firmware/efi: Constify attribute_group structures

Commit-ID:  3ad6bd7c0a1c49a78d00001cfda3d474c23bc354
Gitweb:     http://git.kernel.org/tip/3ad6bd7c0a1c49a78d00001cfda3d474c23bc354
Author:     Arvind Yadav <arvind.yadav.cs@...il.com>
AuthorDate: Fri, 18 Aug 2017 20:49:46 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Mon, 21 Aug 2017 09:43:51 +0200

firmware/efi: Constify attribute_group structures

attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20170818194947.19347-14-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/firmware/efi/efi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 045d6d3..6519be44 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -179,7 +179,7 @@ static umode_t efi_attr_is_visible(struct kobject *kobj,
 	return attr->mode;
 }
 
-static struct attribute_group efi_subsys_attr_group = {
+static const struct attribute_group efi_subsys_attr_group = {
 	.attrs = efi_subsys_attrs,
 	.is_visible = efi_attr_is_visible,
 };