lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 21 Aug 2017 02:20:52 -0700 From: tip-bot for Matthias Kaehlcke <tipbot@...or.com> To: linux-tip-commits@...r.kernel.org Cc: mka@...omium.org, hpa@...or.com, keescook@...omium.org, ndesaulniers@...gle.com, ghackmann@...gle.com, torvalds@...ux-foundation.org, yamada.masahiro@...ionext.com, srhines@...gle.com, arnd@...db.de, tglx@...utronix.de, mingo@...nel.org, linux-kernel@...r.kernel.org, peterz@...radead.org, md@...gle.com, fengguang.wu@...el.com Subject: [tip:x86/build] x86/build: Use cc-option to validate stack alignment parameter Commit-ID: 9e8730b178a2472fca3123e909d6e69cc8127778 Gitweb: http://git.kernel.org/tip/9e8730b178a2472fca3123e909d6e69cc8127778 Author: Matthias Kaehlcke <mka@...omium.org> AuthorDate: Thu, 17 Aug 2017 11:20:47 -0700 Committer: Ingo Molnar <mingo@...nel.org> CommitDate: Mon, 21 Aug 2017 09:53:15 +0200 x86/build: Use cc-option to validate stack alignment parameter With the following commit: 8f91869766c0 ("x86/build: Fix stack alignment for CLang") cc-option is only used to determine the name of the stack alignment option supported by the compiler, but not to verify that the actual parameter <option>=N is valid in combination with the other CFLAGS. This causes problems (as reported by the kbuild robot) with older GCC versions which only support stack alignment on a boundary of 16 bytes or higher. Also use (__)cc_option to add the stack alignment option to CFLAGS to make sure only valid options are added. Reported-by: kbuild test robot <fengguang.wu@...el.com> Signed-off-by: Matthias Kaehlcke <mka@...omium.org> Cc: Arnd Bergmann <arnd@...db.de> Cc: Bernhard.Rosenkranzer@...aro.org Cc: Greg Hackmann <ghackmann@...gle.com> Cc: Kees Cook <keescook@...omium.org> Cc: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com> Cc: Michael Davidson <md@...gle.com> Cc: Nick Desaulniers <ndesaulniers@...gle.com> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Stephen Hines <srhines@...gle.com> Cc: Thomas Gleixner <tglx@...utronix.de> Cc: dianders@...omium.org Fixes: 8f91869766c0 ("x86/build: Fix stack alignment for CLang") Link: http://lkml.kernel.org/r/20170817182047.176752-1-mka@chromium.org Signed-off-by: Ingo Molnar <mingo@...nel.org> --- arch/x86/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 48f3ae7..6276572 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -38,7 +38,7 @@ REALMODE_CFLAGS := $(M16_CFLAGS) -g -Os -D__KERNEL__ \ REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -ffreestanding) REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), -fno-stack-protector) -REALMODE_CFLAGS += $(cc_stack_align4) +REALMODE_CFLAGS += $(call __cc-option, $(CC), $(REALMODE_CFLAGS), $(cc_stack_align4)) export REALMODE_CFLAGS # BITS is used as extension for files which are available in a 32 bit @@ -78,7 +78,7 @@ ifeq ($(CONFIG_X86_32),y) # Align the stack to the register width instead of using the default # alignment of 16 bytes. This reduces stack usage and the number of # alignment instructions. - KBUILD_CFLAGS += $(cc_stack_align4) + KBUILD_CFLAGS += $(call cc-option,$(cc_stack_align4)) # Disable unit-at-a-time mode on pre-gcc-4.0 compilers, it makes gcc use # a lot more stack due to the lack of sharing of stacklots: @@ -117,7 +117,7 @@ else # default alignment which keep the stack *mis*aligned. # Furthermore an alignment to the register width reduces stack usage # and the number of alignment instructions. - KBUILD_CFLAGS += $(cc_stack_align8) + KBUILD_CFLAGS += $(call cc-option,$(cc_stack_align8)) # Use -mskip-rax-setup if supported. KBUILD_CFLAGS += $(call cc-option,-mskip-rax-setup)
Powered by blists - more mailing lists