linux-kernel - Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ee13b12-ef75-bd8d-868f-b17158654a21@amd.com>
Date:   Mon, 21 Aug 2017 15:25:33 +0530
From:   Sandeep Singh <ssingh1@....com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Ben Hutchings <ben@...adent.org.uk>
Cc:     Sandeep Singh <Sandeep.Singh@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        stable@...r.kernel.org,
        Nehal Shah <Nehal-bakulchandra.Shah@....com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP
 keyboard on reset after resume


>>> From: Sandeep Singh <sandeep.singh@....com>
>>>
>>> commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream.
>> [...]
>>> --- a/drivers/usb/host/pci-quirks.c
>>> +++ b/drivers/usb/host/pci-quirks.c
>>> @@ -98,6 +98,7 @@ enum amd_chipset_gen {
>>>  	AMD_CHIPSET_HUDSON2,
>>>  	AMD_CHIPSET_BOLTON,
>>>  	AMD_CHIPSET_YANGTZE,
>>> +	AMD_CHIPSET_TAISHAN,
>>>  	AMD_CHIPSET_UNKNOWN,
>>>  };
>>>  
>>> @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru
>>>  			pinfo->sb_type.gen = AMD_CHIPSET_SB700;
>>>  		else if (rev >= 0x40 && rev <= 0x4f)
>>>  			pinfo->sb_type.gen = AMD_CHIPSET_SB800;
>>> +	}
>>> +	pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
>>> +					  0x145c, NULL);
>>> +	if (pinfo->smbus_dev) {
>>> +		pinfo->sb_type.gen = AMD_CHIPSET_TAISHAN;
>>>  	} else {
>>>  		pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
>>>  				PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
>> [...]
>>
>> This causes pinfo->smbus_dev to be wrongly set to NULL on systems with
>> the ATI chipset that this function checks for first.
> 
> Ugh, for such a "simple" quirk, this has gone through so many different
> iterations, all of which seem broken :(
> 
> Sandeep, can you fix this up and send a follow-on patch to us and the
> linux-usb mailing list so we can get it fixed up properly?
> 

Greg, :-( We will send follow-on patch shortly.