linux-kernel - Re: [PATCH 3/3] [media] radio: constify usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2017 11:03:11 +0100
From:   Alexey Klimov <klimov.linux@...il.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Antti Palosaari <crope@....fi>, mchehab@...nel.org,
        ezequiel@...guardiasur.com.ar,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        royale@...ezo.com, sean@...s.org,
        Hans Verkuil <hverkuil@...all.nl>,
        Linux Media <linux-media@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] [media] radio: constify usb_device_id

Hi Arvind,

thanks for the patch!

On Sun, Aug 13, 2017 at 9:54 AM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

For dsbr100, radio-mr800 and radio-ma901 please feel free to use:

Acked-by: Alexey Klimov <klimov.linux@...il.com>


> ---
>  drivers/media/radio/dsbr100.c                 | 2 +-
>  drivers/media/radio/radio-keene.c             | 2 +-
>  drivers/media/radio/radio-ma901.c             | 2 +-
>  drivers/media/radio/radio-mr800.c             | 2 +-
>  drivers/media/radio/radio-raremono.c          | 2 +-
>  drivers/media/radio/radio-shark.c             | 2 +-
>  drivers/media/radio/radio-shark2.c            | 2 +-
>  drivers/media/radio/si470x/radio-si470x-usb.c | 2 +-
>  drivers/media/radio/si4713/radio-usb-si4713.c | 2 +-
>  9 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/media/radio/dsbr100.c b/drivers/media/radio/dsbr100.c
> index 53bc8c0..8521bb2 100644


[...]

Best regards,
Alexey