linux-kernel - Re: [PATCH v3 1/4] mmc: sdhci-cadence: add suspend / resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2017 21:29:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Piotr Sroka <piotrs@...ence.com>, Hu Ziji <huziji@...vell.com>,
        Christian Daudt <csd@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Zhangfei Gao <zhangfei.gao@...vell.com>,
        Kevin Hao <haokexin@...il.com>,
        Olof Johansson <olof@...om.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v3 1/4] mmc: sdhci-cadence: add suspend / resume support

Hi Adrian,


2017-08-21 20:48 GMT+09:00 Adrian Hunter <adrian.hunter@...el.com>:

>> +static int sdhci_cdns_resume(struct device *dev)
>> +{
>> +     struct sdhci_host *host = dev_get_drvdata(dev);
>> +     struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> +     struct sdhci_cdns_priv *priv = sdhci_pltfm_priv(pltfm_host);
>> +     int ret;
>> +
>> +     ret = clk_prepare_enable(pltfm_host->clk);
>> +     if (ret)
>> +             return ret;
>> +
>> +     ret = sdhci_cdns_phy_init(priv);
>> +     if (ret)
>> +             return ret;
>
> Perhaps clk_disable_unprepare(pltfm_host->clk)
>
>> +
>> +     return sdhci_resume_host(host);
>
> Ditto on error.

Thanks.

Maybe 3/4 should be fixed as well.




-- 
Best Regards
Masahiro Yamada