linux-kernel - Re: [PATCH] mmc: vub300: constify usb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFoF0xK+3Z4VvECLN8xTyAsdO7UZfMWZdr7b5nGoidf2HQ@mail.gmail.com>
Date:   Mon, 21 Aug 2017 14:33:16 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Tony Olech <tony.olech@...ndigitalsystems.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: vub300: constify usb_device_id

On 9 August 2017 at 19:50, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/vub300.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index fbeea1a..6c99102 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -266,7 +266,7 @@ MODULE_PARM_DESC(firmware_rom_wait_states,
>  #define ELAN_VENDOR_ID         0x2201
>  #define VUB300_VENDOR_ID       0x0424
>  #define VUB300_PRODUCT_ID      0x012C
> -static struct usb_device_id vub300_table[] = {
> +static const struct usb_device_id vub300_table[] = {
>         {USB_DEVICE(ELAN_VENDOR_ID, VUB300_PRODUCT_ID)},
>         {USB_DEVICE(VUB300_VENDOR_ID, VUB300_PRODUCT_ID)},
>         {} /* Terminating entry */
> --
> 2.7.4
>