linux-kernel - Re: [PATCH v2] net: ibm: emac: Fix some error handling path in 'emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170820.195320.1737734418974269546.davem@davemloft.net>
Date:   Sun, 20 Aug 2017 19:53:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     christophe.jaillet@...adoo.fr
Cc:     chunkeey@...glemail.com, jarod@...hat.com, ivan@...ibm.com,
        ebiggers@...gle.com, tklauser@...tanz.ch, tremyfr@...il.com,
        robh@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] net: ibm: emac: Fix some error handling path in
 'emac_probe()'

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Sun, 20 Aug 2017 06:35:00 +0200

> If 'irq_of_parse_and_map()' or 'of_address_to_resource()' fail, 'err' is
> known to be 0 at this point.
> So return -ENODEV instead in the first case and use 'of_iomap()' instead of
> the equivalent 'of_address_to_resource()/ioremap()' combinaison in the 2nd
> case.
> 
> Doing so, the 'rsrc_regs' field of the 'emac_instance struct' becomes
> redundant and is removed.
> 
> While at it, turn a 'err != 0' test into an equivalent 'err' to be more
> consistent.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> v2: use of_iomap() to simplify code
>     remove 'rsrc_regs' field of the 'emac_instance struct'
>     update comment

Applied to net-next.