linux-kernel - Re: system hung up when offlining CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fce0ad52-8739-09c8-ec9d-a23eb92cec5a@arm.com>
Date:   Mon, 21 Aug 2017 14:37:57 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Christoph Hellwig <hch@....de>
Cc:     YASUAKI ISHIMATSU <yasu.isimatu@...il.com>, tglx@...utronix.de,
        axboe@...nel.dk, mpe@...erman.id.au, keith.busch@...el.com,
        peterz@...radead.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: system hung up when offlining CPUs

On 21/08/17 14:18, Christoph Hellwig wrote:
> Can you try the patch below please?
> 
> ---
> From d5f59cb7a629de8439b318e1384660e6b56e7dd8 Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@....de>
> Date: Mon, 21 Aug 2017 14:24:11 +0200
> Subject: virtio_pci: fix cpu affinity support
> 
> Commit 0b0f9dc5 ("Revert "virtio_pci: use shared interrupts for
> virtqueues"") removed the adjustment of the pre_vectors for the virtio
> MSI-X vector allocation which was added in commit fb5e31d9 ("virtio:
> allow drivers to request IRQ affinity when creating VQs"). This will
> lead to an incorrect assignment of MSI-X vectors, and potential
> deadlocks when offlining cpus.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Fixes: 0b0f9dc5 ("Revert "virtio_pci: use shared interrupts for virtqueues")
> Reported-by: YASUAKI ISHIMATSU <yasu.isimatu@...il.com>

Just gave it a go on an arm64 VM, and the behaviour seems much saner
(the virtio queue affinity now spans the whole system).

Tested-by: Marc Zyngier <marc.zyngier@....com>

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...