linux-kernel - Re: [PATCH 2/4] isofs: Adjust four checks for null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Aug 2017 16:06:31 +0200
From:   Jan Kara <jack@...e.cz>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>,
        Ingo Molnar <mingo@...nel.org>, Jan Kara <jack@...e.cz>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] isofs: Adjust four checks for null pointers

On Sat 19-08-17 09:17:28, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 18 Aug 2017 21:47:14 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The script “checkpatch.pl” pointed information out like the following.
> 
> Comparison to NULL could be written !…
> 
> Thus fix the affected source code places.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Thanks. Applied to my tree.

								Honza


> ---
>  fs/isofs/inode.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index 2d3f090944df..db43f52f2268 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -96,7 +96,7 @@ static int __init init_inodecache(void)
>  					0, (SLAB_RECLAIM_ACCOUNT|
>  					SLAB_MEM_SPREAD|SLAB_ACCOUNT),
>  					init_once);
> -	if (isofs_inode_cachep == NULL)
> +	if (!isofs_inode_cachep)
>  		return -ENOMEM;
>  	return 0;
>  }
> @@ -678,7 +678,7 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent)
>  			if (isonum_711(vdp->type) == ISO_VD_END)
>  				break;
>  			if (isonum_711(vdp->type) == ISO_VD_PRIMARY) {
> -				if (pri == NULL) {
> +				if (!pri) {
>  					pri = (struct iso_primary_descriptor *)vdp;
>  					/* Save the buffer in case we need it ... */
>  					pri_bh = bh;
> @@ -742,7 +742,7 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent)
>  		goto out_freebh;
>  	}
>  
> -	if (joliet_level && (pri == NULL || !opt.rock)) {
> +	if (joliet_level && (!pri || !opt.rock)) {
>  		/* This is the case of Joliet with the norock mount flag.
>  		 * A disc with both Joliet and Rock Ridge is handled later
>  		 */
> @@ -1320,5 +1320,5 @@ static int isofs_read_inode(struct inode *inode, int relocated)
>  		int frag1 = bufsize - offset;
>  
>  		tmpde = kmalloc(de_len, GFP_KERNEL);
> -		if (tmpde == NULL) {
> +		if (!tmpde) {
>  			ret = -ENOMEM;
> -- 
> 2.14.0
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR