linux-kernel - Re: [PATCH 1/3] soc: qcom: smem: Support global partition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1653d6e0-e62d-f341-3911-bd2b307ba885@codeaurora.org>
Date:   Mon, 21 Aug 2017 11:35:15 +0530
From:   Arun Kumar Neelakantam <aneela@...eaurora.org>
To:     Chris Lew <clew@...eaurora.org>, bjorn.andersson@...aro.org,
        andy.gross@...aro.org, david.brown@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] soc: qcom: smem: Support global partition



On 8/18/2017 6:45 AM, Chris Lew wrote:
> @@ -782,7 +855,10 @@ static int qcom_smem_probe(struct platform_device *pdev)
>   	}
>   
>   	version = qcom_smem_get_sbl_version(smem);
> -	if (version >> 16 != SMEM_EXPECTED_VERSION) {
> +	switch (version >> 16) {
> +	case SMEM_GLOBAL_PART_VERSION:
> +	case SMEM_GLOBAL_HEAP_VERSION:
break statement is needed for supported versions
> +	default:
>   		dev_err(&pdev->dev, "Unsupported SMEM version 0x%x\n", version);
>   		return -EINVAL;
>   	}