linux-kernel - Re: [PATCH] mfd: max77693: Add muic of_compatible in mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170821175838.g6cvtwqgvtw4n2es@kozik-lap>
Date:   Mon, 21 Aug 2017 19:58:38 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Maciej Purski <m.purski@...sung.com>
Cc:     linux-kernel@...r.kernel.org, cw00.choi@...sung.com,
        lee.jones@...aro.org, b.zolnierkie@...sung.com
Subject: Re: [PATCH] mfd: max77693: Add muic of_compatible in mfd_cell

On Mon, Aug 21, 2017 at 12:53:43PM +0200, Maciej Purski wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.

Please document it in similar way as in for example
Documentation/devicetree/bindings/mfd/max14577.txt
or in other way.

Best regards,
Krzysztof

> 
> Signed-off-by: Maciej Purski <m.purski@...sung.com>
> ---
>  drivers/mfd/max77693.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>  		.name = "max77693-charger",
>  		.of_compatible = "maxim,max77693-charger",
>  	},
> -	{ .name = "max77693-muic", },
> +	{
> +		.name = "max77693-muic",
> +		.of_compatible = "maxim,max77693-muic",
> +	},
>  	{
>  		.name = "max77693-haptic",
>  		.of_compatible = "maxim,max77693-haptic",
> -- 
> 2.7.4
>