linux-kernel - Re: Possible null pointer dereference in rcar-dmac.ko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878tidcv1m.wl%kuninori.morimoto.gx@renesas.com>
Date:   Mon, 21 Aug 2017 06:15:13 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Vinod Koul <vinod.koul@...el.com>,
        Niklas Söderlund 
        <niklas.soderlund+renesas@...natech.se>,
        Dan Williams <dan.j.williams@...el.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux-Kernel <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Anton Volkov <avolkov@...ras.ru>,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        ldv-project@...uxtesting.org, dmaengine@...r.kernel.org,
        geert+renesas@...der.be
Subject: Re: Possible null pointer dereference in rcar-dmac.ko


Hi Laurent

> I don't think this fully fixes the problem, as the rcar_dmac_isr_error() IRQ 
> handler is still registered before all this. Furthermore, at least some of the 
> initialization at the end of rcar_dmac_chan_probe() has to be moved before the 
> rcar_dmac_isr_channel() IRQ handler registration.
> 
> Let's not commit a quick hack but fix the problem correctly, we should ensure 
> that all the initialization needed by IRQ handlers is performed before they 
> get registered.

Yeah, indeed.
We need v2 patch

Best regards
---
Kuninori Morimoto