linux-kernel - Re: [PATCH v4 1/3] ASoC: codecs: msm8916-wcd-analog: get micbias voltage from dt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170821182409.c6vnzcuomrygrwjh@sirena.org.uk>
Date:   Mon, 21 Aug 2017 19:24:09 +0100
From:   Mark Brown <broonie@...nel.org>
To:     srinivas.kandagatla@...aro.org
Cc:     Banajit Goswami <bgoswami@...eaurora.org>,
        alsa-devel@...a-project.org, damien.riegel@...oirfairelinux.com,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Patrick Lai <plai@...eaurora.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/3] ASoC: codecs: msm8916-wcd-analog: get micbias
 voltage from dt

On Thu, Aug 17, 2017 at 10:02:09AM +0200, srinivas.kandagatla@...aro.org wrote:

> +		/*
> +		 * Special headset needs MICBIAS as 2.7V so wait for
> +		 * 50 msec for the MICBIAS to reach 2.7 volts.
> +		 */
> +		if (wcd->micbias_mv >= 2700)
> +			msleep(50);

This doesn't sound like how ramping usually works?  Normally it'd be at
least somewhat proportional to voltage, a sudden cutoff like this seems
strange.  I'll apply but this looks like it needs fixing, please send an
incremental patch.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)