linux-kernel - Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLWxnxViB1EqZsvdsAFHPuoDnn0X2ZOtEMkh5KWNAk4o2w@mail.gmail.com>
Date:   Mon, 21 Aug 2017 11:48:39 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Martijn Coenen <maco@...roid.com>, Todd Kjos <tkjos@...gle.com>,
        Arve Hjønnevåg <arve@...roid.com>,
        Amit Pundir <amit.pundir@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>, devel@...verdev.osuosl.org,
        Martijn Coenen <maco@...gle.com>
Subject: Re: [PATCH 3/3] ANDROID: binder: fix proc->tsk check.

On Tue, Aug 8, 2017 at 11:08 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Tue, Aug 08, 2017 at 10:34:47AM -0700, John Stultz wrote:
>> On Fri, Jul 28, 2017 at 4:56 AM, Martijn Coenen <maco@...roid.com> wrote:
>> > Commit c4ea41ba195d ("binder: use group leader instead of open thread")'
>> > was incomplete and didn't update a check in binder_mmap(), causing all
>> > mmap() calls into the binder driver to fail.
>> >
>> > Signed-off-by: Martijn Coenen <maco@...roid.com>
>> > ---
>> >  drivers/android/binder.c | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/drivers/android/binder.c b/drivers/android/binder.c
>> > index f7665c31feca..831cdd7d197d 100644
>> > --- a/drivers/android/binder.c
>> > +++ b/drivers/android/binder.c
>> > @@ -3362,7 +3362,7 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
>> >         const char *failure_string;
>> >         struct binder_buffer *buffer;
>> >
>> > -       if (proc->tsk != current)
>> > +       if (proc->tsk != current->group_leader)
>> >                 return -EINVAL;
>> >
>> >         if ((vma->vm_end - vma->vm_start) > SZ_4M)
>>
>> Tested-by: John Stultz <john.stultz@...aro.org>
>>
>> As Amit already confirmed, this resolves the wifi and bluetooth
>> regression I was seeing with Android using 4.13-rc2.
>>
>> Though I've not seen it show up in Linus' tree yet, so I wanted to
>> pester folks so it gets into 4.13-rc (its given me some slight grief
>> trying to bisect down a separate issue).
>
> I will queue this up in the next few days, I need to resolve the patches
> that have been sent to me for this, sorry for the delay.

Hey Greg,
  Sorry to pester you again on this, but this seems to still be
missing in -rc6. Don't want it to slip by.

thanks
-john