linux-kernel - Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard front driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKdAkRQf5J4xH5a-6s73c2OSRa=fVyhR0XfEGmqTopyrK812kA@mail.gmail.com>
Date:   Mon, 21 Aug 2017 13:28:05 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>
Cc:     Liang Yan <lyan@...e.com>, xen-devel@...ts.xenproject.org,
        Juergen Gross <jgross@...e.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] XEN/xen-kbdfront: Enable auto repeat for xen keyboard
 front driver

On Mon, Aug 21, 2017 at 12:30 PM, Boris Ostrovsky
<boris.ostrovsky@...cle.com> wrote:
>
> Adding maintainer (Dmitry).

I can't seem to find the original in my mailbox nor in patchwork. Can
you please resend?

>
>
> -boris
>
> On 08/21/2017 11:41 AM, Liang Yan wrote:
> > Long pressed key could not show right in XEN vncviewer after tigervnc
> > client changed the way how to send repeat keys, from "Down Up Down Up
> > ..." to "Down Down Dow." By enable EV_REP bit here, XEN keyboard
> > device will trigger default auto repeat process from input subsystem,
> > and make auto repeat keys work correctly.
> >
> > Signed-off-by: Liang Yan <lyan@...e.com>
> > ---
> >  drivers/input/misc/xen-kbdfront.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/input/misc/xen-kbdfront.c
> > b/drivers/input/misc/xen-kbdfront.c
> > index fa130e7b734c..0dce9830e2f4 100644
> > --- a/drivers/input/misc/xen-kbdfront.c
> > +++ b/drivers/input/misc/xen-kbdfront.c
> > @@ -248,6 +248,7 @@ static int xenkbd_probe(struct xenbus_device *dev,
> >  kbd->id.product = 0xffff;
> >
> >  __set_bit(EV_KEY, kbd->evbit);
> > +__set_bit(EV_REP, kbd->evbit);
> >  for (i = KEY_ESC; i < KEY_UNKNOWN; i++)
> >  __set_bit(i, kbd->keybit);
> >  for (i = KEY_OK; i < KEY_MAX; i++)
> > --
> > 2.14.0
> >
>

Thanks.

-- 
Dmitry