linux-kernel - Re: [PATCH -mm -v2] mm: Clear to access sub-page last when clearing huge page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 22 Aug 2017 08:54:15 +0800
From:   "Huang\, Ying" <ying.huang@...el.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     "Huang\, Ying" <ying.huang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Nadia Yvette Chambers <nyc@...omorphy.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        Hugh Dickins <hughd@...gle.com>,
        Minchan Kim <minchan@...nel.org>, Shaohua Li <shli@...com>,
        Christopher Lameter <cl@...ux.com>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [PATCH -mm -v2] mm: Clear to access sub-page last when clearing huge page

Michal Hocko <mhocko@...nel.org> writes:

> On Tue 15-08-17 09:46:18, Huang, Ying wrote:
>> From: Huang Ying <ying.huang@...el.com>
>> 
>> Huge page helps to reduce TLB miss rate, but it has higher cache
>> footprint, sometimes this may cause some issue.  For example, when
>> clearing huge page on x86_64 platform, the cache footprint is 2M.  But
>> on a Xeon E5 v3 2699 CPU, there are 18 cores, 36 threads, and only 45M
>> LLC (last level cache).  That is, in average, there are 2.5M LLC for
>> each core and 1.25M LLC for each thread.  If the cache pressure is
>> heavy when clearing the huge page, and we clear the huge page from the
>> begin to the end, it is possible that the begin of huge page is
>> evicted from the cache after we finishing clearing the end of the huge
>> page.  And it is possible for the application to access the begin of
>> the huge page after clearing the huge page.
>> 
>> To help the above situation, in this patch, when we clear a huge page,
>> the order to clear sub-pages is changed.  In quite some situation, we
>> can get the address that the application will access after we clear
>> the huge page, for example, in a page fault handler.  Instead of
>> clearing the huge page from begin to end, we will clear the sub-pages
>> farthest from the the sub-page to access firstly, and clear the
>> sub-page to access last.  This will make the sub-page to access most
>> cache-hot and sub-pages around it more cache-hot too.  If we cannot
>> know the address the application will access, the begin of the huge
>> page is assumed to be the the address the application will access.
>> 
>> With this patch, the throughput increases ~28.3% in vm-scalability
>> anon-w-seq test case with 72 processes on a 2 socket Xeon E5 v3 2699
>> system (36 cores, 72 threads).  The test case creates 72 processes,
>> each process mmap a big anonymous memory area and writes to it from
>> the begin to the end.  For each process, other processes could be seen
>> as other workload which generates heavy cache pressure.  At the same
>> time, the cache miss rate reduced from ~33.4% to ~31.7%, the
>> IPC (instruction per cycle) increased from 0.56 to 0.74, and the time
>> spent in user space is reduced ~7.9%
>
> The patch looks good to me alebit little bit tricky to read.
>
> But I am still wondering. Have you considered non-temporal stores for
> clearing?

Yes, the non-temporal stores will have no cache pressure to other
processes.  But the cache will be cold for current process too.  That
is, accessing memory after non-temporal stores need synchronous RAM
loading.  And if cache overhead on other cores isn't heavy, we can take
better advantage of the shared last level cache if we use normal memory
clearing.

>> Christopher Lameter suggests to clear bytes inside a sub-page from end
>> to begin too.  But tests show no visible performance difference in the
>> tests.  May because the size of page is small compared with the cache
>> size.
>> 
>> Thanks Andi Kleen to propose to use address to access to determine the
>> order of sub-pages to clear.
>> 
>> The hugetlbfs access address could be improved, will do that in
>> another patch.
>> 
>> [Use address to access information]
>> Suggested-by: Andi Kleen <andi.kleen@...el.com>
>> Signed-off-by: "Huang, Ying" <ying.huang@...el.com>
>> Acked-by: Jan Kara <jack@...e.cz>
>> Cc: Andrea Arcangeli <aarcange@...hat.com>
>> Cc: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
>> Cc: Nadia Yvette Chambers <nyc@...omorphy.com>
>> Cc: Michal Hocko <mhocko@...e.com>
>> Cc: Matthew Wilcox <mawilcox@...rosoft.com>
>> Cc: Hugh Dickins <hughd@...gle.com>
>> Cc: Minchan Kim <minchan@...nel.org>
>> Cc: Shaohua Li <shli@...com>
>> Cc: Christopher Lameter <cl@...ux.com>
>> Cc: Mike Kravetz <mike.kravetz@...cle.com>
>
> Reviewed-by: Michal Hocko <mhocko@...e.com>

Thanks!

>> +	for (i = 0; i < l; i++) {
>
> I would find it a bit easier to read if this was
> 		int left_idx = base + i;
> 		int right_idx = base + 2*l - 1 - i
>
>> +		cond_resched();
>> +		clear_user_highpage(page + base + i,
>> +				    addr + (base + i) * PAGE_SIZE);
> 		clear_user_highpage(page + left_idx, addr + left_idx * PAGE_SIZE);
>
>>  		cond_resched();
>> -		clear_user_highpage(page + i, addr + i * PAGE_SIZE);
>> +		clear_user_highpage(page + base + 2 * l - 1 - i,
>> +				    addr + (base + 2 * l - 1 - i) * PAGE_SIZE);
> 		clear_user_highpage(page + right_idx, addr + right_idx * PAGE_SIZE);
>>  	}
>>  }

Yes.  This looks better.

Best Regards,
Huang, Ying