linux-kernel - Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170822093319.GC25370@mail.corp.redhat.com>
Date:   Tue, 22 Aug 2017 11:33:19 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     JamChen <jam.chen.egalax@...il.com>
Cc:     jikos@...nel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, zboszor@...hu
Subject: Re: [PATCH] HID: core: assign usbhid to handle EETI PID=0x0001 HID
 device

On Aug 11 2017 or thereabouts, JamChen wrote:
> From: Jam Chen <jam.chen.egalax@...il.com>
> 
> The vendor used the same PID(0x0001) for multiple touch IC controllers.
> The newer ICs can support HID class and report the multitouch collection
> in the descriptor. So they were handled by the hid-multitouch driver.
> But some customized firmwares don't support multitouch protocol even if
> driver have got the Win8 blob data.
> 
> Actually, those ICs only support the single touch function, and report
> the mouse protocol by default. We can assign usbhid to handle them all.
> 
> Signed-off-by: Jam Chen <jam.chen.egalax@...il.com>
> ---

Him

FYI, I'd rather see a full working solution such as the one presented here:
https://patchwork.kernel.org/patch/9876649/

Because this solution is half working as it regresses on some devices
while solving others.

Cheers,
Benjamin

>  drivers/hid/hid-core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 9017dcc14502..df4696022488 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -828,6 +828,10 @@ static int hid_scan_report(struct hid_device *hid)
>  				 */
>  				hid->group = HID_GROUP_RMI;
>  		break;
> +	case USB_VENDOR_ID_DWAV:
> +		if (hid->product == USB_DEVICE_ID_EGALAX_TOUCHCONTROLLER)
> +			hid->group = HID_GROUP_GENERIC;
> +		break;
>  	}
>  
>  	/* fall back to generic driver in case specific driver doesn't exist */
> -- 
> 2.11.0
>