lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Aug 2017 16:51:16 +0530 From: Rishabh Hardas <rishabhhardas@...il.com> To: Greg KH <gregkh@...uxfoundation.org> Cc: gilad@...yossef.com, linux-crypto@...r.kernel.org, driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging/ccree: Declare compiled out fuctions static inline On Wed, Aug 16, 2017 at 03:09:09PM -0700, Greg KH wrote: > On Mon, Jul 31, 2017 at 02:47:23PM +0530, RishabhHardas wrote: > > From: RishabhHardas <rishabhhardas@...il.com> > > > > Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler' > > that they were not declared and need to be made static. This patch makes both the symbols > > static inline, to remove the warnings. > > > > Signed-off-by: RishabhHardas <rishabhhardas@...il.com> > > I doubt you sign your name on legal documents without a ' ' somewhere in > it :( > > Please fix up and resend. > > thanks, > > greg k-h From: Rishabh Hardas <rishabhhardas@...il.com> Sparse was giving out a warning for symbols 'cc_set_ree_fips_status' and 'fips_handler' that they were not declared and need to be made static. This patch makes both the symbols static inline, to remove the warnings. Signed-off-by: Rishabh Hardas <rishabhhardas@...il.com> --- drivers/staging/ccree/ssi_fips.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips.h b/drivers/staging/ccree/ssi_fips.h index 369ddf9..63bcca7 100644 --- a/drivers/staging/ccree/ssi_fips.h +++ b/drivers/staging/ccree/ssi_fips.h @@ -40,1 +40,1 @@ static inline int ssi_fips_init(struct ssi_drvdata *p_drvdata) } static inline void ssi_fips_fini(struct ssi_drvdata *drvdata) {} -void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {} -void fips_handler(struct ssi_drvdata *drvdata) {} +static inline void cc_set_ree_fips_status(struct ssi_drvdata *drvdata, bool ok) {} +static inline void fips_handler(struct ssi_drvdata *drvdata) {} #endif /* CONFIG_CRYPTO_FIPS */ -- 1.9.1
Powered by blists - more mailing lists