linux-kernel - Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPeJeMOgQB32ajWT15TLHw6h8cxnf5UFT-dturCfarxv0g@mail.gmail.com>
Date:   Tue, 22 Aug 2017 14:01:13 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Maciej Purski <m.purski@...sung.com>
Cc:     linux-kernel@...r.kernel.org, Chanwoo Choi <cw00.choi@...sung.com>,
        lee.jones@...aro.org,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v3] mfd: max77693: Add muic of_compatible in mfd_cell

On Tue, Aug 22, 2017 at 9:38 AM, Maciej Purski <m.purski@...sung.com> wrote:
> This patch adds muic of_compatible in order to use the muic device
> driver in device tree.
>
> v2:
> - added muic to documentation

Change log should not go to commit message. Put it after separator ---.

+cc devicetree - scripts/get_maintainer.pl should point you that list.

With the change in commit msg:
Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>

Best regards,
Krzysztof

>
> v3:
> - removed duplication
>
> Signed-off-by: Maciej Purski <m.purski@...sung.com>
> ---
>  Documentation/devicetree/bindings/mfd/max77693.txt | 6 ++++++
>  drivers/mfd/max77693.c                             | 5 ++++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt
> index 6a1ae3a..e675497 100644
> --- a/Documentation/devicetree/bindings/mfd/max77693.txt
> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt
> @@ -127,6 +127,12 @@ Required properties for the LED child node:
>  Optional properties for the LED child node:
>  - label : see Documentation/devicetree/bindings/leds/common.txt
>
> +Optional nodes:
> +- max77693-muic :
> +       Node used only by extcon consumers.
> +       Required properties:
> +               - compatible : "maxim,max77693-muic"
> +
>  Example:
>  #include <dt-bindings/leds/common.h>
>
> diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
> index 662ae0d..1c05ea0 100644
> --- a/drivers/mfd/max77693.c
> +++ b/drivers/mfd/max77693.c
> @@ -48,7 +48,10 @@ static const struct mfd_cell max77693_devs[] = {
>                 .name = "max77693-charger",
>                 .of_compatible = "maxim,max77693-charger",
>         },
> -       { .name = "max77693-muic", },
> +       {
> +               .name = "max77693-muic",
> +               .of_compatible = "maxim,max77693-muic",
> +       },
>         {
>                 .name = "max77693-haptic",
>                 .of_compatible = "maxim,max77693-haptic",
> --
> 2.7.4
>