linux-kernel - Re: [PATCH] pids: make task_tgid_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170822122030.GA2193@redhat.com>
Date:   Tue, 22 Aug 2017 14:20:30 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Troy Kensinger <tkensinger@...gle.com>,
        "security@...nel.org" <security@...nel.org>,
        Paul McKenney <paulmck@...ux.vnet.ibm.com>,
        Josh Triplett <josh@...htriplett.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] pids: make task_tgid_nr_ns() safe

On 08/21, Linus Torvalds wrote:
>
> On Mon, Aug 21, 2017 at 8:35 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > We really need to change __unhash_process() to nullify group_leader,
> > parent, and real_parent, but this needs some cleanups. Until then we
> > can turn task_tgid_nr_ns() into another user of __task_pid_nr_ns() and
> > fix the problem.
>
> Applied.
>
> Should it perhaps have had a "Cc: stable" on it? I didn't do so, but
> it might be worth pointing Greg at this explicitly (dd1c1f2f2028
> "pids: make task_tgid_nr_ns() safe").

Yes, agreed, I forgot to add this tag.

Oleg.