linux-kernel - Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hziar9483.wl-tiwai@suse.de>
Date:   Tue, 22 Aug 2017 14:28:12 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Dan Carpenter" <dan.carpenter@...cle.com>
Cc:     "SF Markus Elfring" <elfring@...rs.sourceforge.net>,
        <alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
        <kernel-janitors@...r.kernel.org>,
        "LKML" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()

On Tue, 22 Aug 2017 14:16:25 +0200,
Dan Carpenter wrote:
> 
>   	err = snd_card_register(card);
> > -	if (err < 0) {
> > +	if (err) {
> > +free_card:
> >  		snd_card_free(card);
> >  		return err;
> >  	}
> 
> I thought we agreed, yesterday, to never use this style of error
> handling?

Yeah, this is definitely no-go.

Also, please don't omit the negative value check.


thanks,

Takashi