linux-kernel - Re: [PATCH 11/18] rpmsg: glink: Use the local intents when receiving data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65d6412f-ee00-09b1-59ee-7ff20d65827b@codeaurora.org>
Date:   Tue, 22 Aug 2017 18:09:01 +0530
From:   Sricharan R <sricharan@...eaurora.org>
To:     Arun Kumar Neelakantam <aneela@...eaurora.org>, ohad@...ery.com,
        bjorn.andersson@...aro.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 11/18] rpmsg: glink: Use the local intents when receiving
 data

Hi,

<snip..>

>>   -    /* Might have an ongoing, fragmented, message to append */
>> -    if (!channel->buf) {
>> -        channel->buf = kmalloc(chunk_size + left_size, GFP_ATOMIC);
>> -        if (!channel->buf)
>> -            return -ENOMEM;
>> +    if (glink->intentless) {
>> +        /* Might have an ongoing, fragmented, message to append */
>> +        if (!channel->buf) {
>> +            intent = kzalloc(sizeof(*intent), GFP_ATOMIC);
>> +            if (!intent)
>> +                return -ENOMEM;
>> +
>> +            intent->data = kmalloc(chunk_size + left_size,
>> +                           GFP_ATOMIC);
> 
> Who is supposed to free the intent and intent->data memory ?
 Well, that's done as a part of the rx_done_work.

Regards,
 Sricharan
 
-- 
"QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus