linux-kernel - Re: [PATCH 15/15] usb: make device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170822125517.GA27604@kuha.fi.intel.com>
Date:   Tue, 22 Aug 2017 15:55:17 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, bp@...en8.de, mchehab@...nel.org,
        daniel.vetter@...el.com, jani.nikula@...ux.intel.com,
        seanpaul@...omium.org, airlied@...ux.ie, g.liakhovetski@....de,
        tomas.winkler@...el.com, dwmw2@...radead.org,
        computersforpeace@...il.com, boris.brezillon@...e-electrons.com,
        marek.vasut@...il.com, richard@....at, cyrille.pitchen@...ev4u.fr,
        peda@...ntia.se, kishon@...com, bhelgaas@...gle.com,
        thierry.reding@...il.com, jonathanh@...dia.com,
        dvhart@...radead.org, andy@...radead.org, ohad@...ery.com,
        bjorn.andersson@...aro.org, freude@...ibm.com,
        schwidefsky@...ibm.com, heiko.carstens@...ibm.com, jth@...nel.org,
        jejb@...ux.vnet.ibm.com, martin.petersen@...cle.com,
        lduncan@...e.com, cleech@...hat.com, johan@...nel.org,
        elder@...nel.org, gregkh@...uxfoundation.org,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-media@...r.kernel.org,
        linux-mtd@...ts.infradead.org, linux-pci@...r.kernel.org,
        linux-tegra@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-s390@...r.kernel.org,
        fcoe-devel@...n-fcoe.org, linux-scsi@...r.kernel.org,
        open-iscsi@...glegroups.com, greybus-dev@...ts.linaro.org,
        devel@...verdev.osuosl.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 15/15] usb: make device_type const

On Sat, Aug 19, 2017 at 01:52:26PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the type field of a device
> structure, which is const.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/common/ulpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index 930e8f3..4aa5195 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -135,7 +135,7 @@ static void ulpi_dev_release(struct device *dev)
>  	kfree(to_ulpi_dev(dev));
>  }
>  
> -static struct device_type ulpi_dev_type = {
> +static const struct device_type ulpi_dev_type = {
>  	.name = "ulpi_device",
>  	.groups = ulpi_dev_attr_groups,
>  	.release = ulpi_dev_release,

Thanks,

-- 
heikki