linux-kernel - Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <599C420A.80601@rock-chips.com>
Date:   Tue, 22 Aug 2017 22:39:06 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>
CC:     Donglin Peng <dolinux.peng@...il.com>, alsa-devel@...a-project.org,
        briannorris@...omium.org, dgreid@...omium.org,
        dianders@...omium.org, mka@...omium.org,
        Liam Girdwood <lgirdwood@...il.com>,
        mengdong.lin@...ux.intel.com, lars@...afoo.de,
        Jaroslav Kysela <perex@...ex.cz>,
        Heiko Stübner <heiko@...ech.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name
 in snd_soc_find_dai

Hi guys,

On 08/22/2017 10:26 PM, Takashi Iwai wrote:
> On Tue, 22 Aug 2017 16:21:11 +0200,
> Mark Brown wrote:
>>
>> On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote:
>>> On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown <broonie@...nel.org> wrote:
>>
>>>> We should be already verifying that drivers have a name, we assume one
>>>> elsewhere.
>>
>>> But I can't find any codes that set or check dai_driver->name in
>>> function snd_soc_register_codec or snd_soc_register_component.
>>
>> We should fix that then.
>
> Hmm, as far as I read the code, the NULL dai driver name is valid for
> a single component.  The dai name is determined by fmt_single_name().
>
>
> Takashi
>
>
sorry, i though that is checked too... new patch is coming, thanks for 
noticing :)
>