linux-kernel - Re: [PATCH 1/4] i2c: busses: make i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9831a3fd-829d-9165-20f9-9cd341e5646b@caviumnetworks.com>
Date:   Tue, 22 Aug 2017 09:39:14 -0700
From:   David Daney <ddaney@...iumnetworks.com>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        wsa@...-dreams.de, jacmet@...site.dk, jglauber@...ium.com,
        david.daney@...ium.com, hans.verkuil@...co.com, mchehab@...nel.org,
        awalls@...metrocast.net, serjk@...up.ru, aospan@...up.ru,
        isely@...ox.com, ezequiel@...guardiasur.com.ar,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH 1/4] i2c: busses: make i2c_adapter const

On 08/19/2017 03:34 AM, Bhumika Goyal wrote:
> Make these const as they are only used in a copy operation.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>



i2c-octeon-platdrv.c and i2c-thunderx-pcidrv.c changes:

Acked-by: David Daney <david.daney@...ium.com>

Thanks.

> ---
>   drivers/i2c/busses/i2c-kempld.c          | 2 +-
>   drivers/i2c/busses/i2c-ocores.c          | 2 +-
>   drivers/i2c/busses/i2c-octeon-platdrv.c  | 2 +-
>   drivers/i2c/busses/i2c-thunderx-pcidrv.c | 2 +-
>   drivers/i2c/busses/i2c-xiic.c            | 2 +-
>   5 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-kempld.c b/drivers/i2c/busses/i2c-kempld.c
> index 25993d2..e879190 100644
> --- a/drivers/i2c/busses/i2c-kempld.c
> +++ b/drivers/i2c/busses/i2c-kempld.c
> @@ -289,7 +289,7 @@ static u32 kempld_i2c_func(struct i2c_adapter *adap)
>   	.functionality	= kempld_i2c_func,
>   };
>   
> -static struct i2c_adapter kempld_i2c_adapter = {
> +static const struct i2c_adapter kempld_i2c_adapter = {
>   	.owner		= THIS_MODULE,
>   	.name		= "i2c-kempld",
>   	.class		= I2C_CLASS_HWMON | I2C_CLASS_SPD,
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index 34f1889..8c42ca7 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -276,7 +276,7 @@ static u32 ocores_func(struct i2c_adapter *adap)
>   	.functionality = ocores_func,
>   };
>   
> -static struct i2c_adapter ocores_adapter = {
> +static const struct i2c_adapter ocores_adapter = {
>   	.owner = THIS_MODULE,
>   	.name = "i2c-ocores",
>   	.class = I2C_CLASS_DEPRECATED,
> diff --git a/drivers/i2c/busses/i2c-octeon-platdrv.c b/drivers/i2c/busses/i2c-octeon-platdrv.c
> index 917524c..64bda83 100644
> --- a/drivers/i2c/busses/i2c-octeon-platdrv.c
> +++ b/drivers/i2c/busses/i2c-octeon-platdrv.c
> @@ -126,7 +126,7 @@ static u32 octeon_i2c_functionality(struct i2c_adapter *adap)
>   	.functionality = octeon_i2c_functionality,
>   };
>   
> -static struct i2c_adapter octeon_i2c_ops = {
> +static const struct i2c_adapter octeon_i2c_ops = {
>   	.owner = THIS_MODULE,
>   	.name = "OCTEON adapter",
>   	.algo = &octeon_i2c_algo,
> diff --git a/drivers/i2c/busses/i2c-thunderx-pcidrv.c b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
> index ea35a895..df0976f 100644
> --- a/drivers/i2c/busses/i2c-thunderx-pcidrv.c
> +++ b/drivers/i2c/busses/i2c-thunderx-pcidrv.c
> @@ -75,7 +75,7 @@ static u32 thunderx_i2c_functionality(struct i2c_adapter *adap)
>   	.functionality = thunderx_i2c_functionality,
>   };
>   
> -static struct i2c_adapter thunderx_i2c_ops = {
> +static const struct i2c_adapter thunderx_i2c_ops = {
>   	.owner	= THIS_MODULE,
>   	.name	= "ThunderX adapter",
>   	.algo	= &thunderx_i2c_algo,
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index 34b27bf..ae6ed25 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -721,7 +721,7 @@ static u32 xiic_func(struct i2c_adapter *adap)
>   	.functionality = xiic_func,
>   };
>   
> -static struct i2c_adapter xiic_adapter = {
> +static const struct i2c_adapter xiic_adapter = {
>   	.owner = THIS_MODULE,
>   	.name = DRIVER_NAME,
>   	.class = I2C_CLASS_DEPRECATED,
>