linux-kernel - linux-next: build failure after merge of the slave-dma tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2017 15:36:54 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stefan Roese <sr@...x.de>, Dave Jiang <dave.jiang@...el.com>
Subject: linux-next: build failure after merge of the slave-dma tree

Hi Vinod,

After merging the slave-dma tree, today's linux-next build (x86_64
allmodconfig) failed like this:

In file included from drivers/dma/dmaengine.h:9:0,
                 from drivers/dma/altera-msgdma.c:27:
drivers/dma/altera-msgdma.c: In function 'msgdma_probe':
drivers/dma/altera-msgdma.c:946:14: error: 'DMA_SG' undeclared (first use in this function)
  dma_cap_set(DMA_SG, dma_dev->cap_mask);
              ^
include/linux/dmaengine.h:1197:46: note: in definition of macro 'dma_cap_set'
 #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask))
                                              ^
drivers/dma/altera-msgdma.c:946:14: note: each undeclared identifier is reported only once for each function it appears in
  dma_cap_set(DMA_SG, dma_dev->cap_mask);
              ^
include/linux/dmaengine.h:1197:46: note: in definition of macro 'dma_cap_set'
 #define dma_cap_set(tx, mask) __dma_cap_set((tx), &(mask))
                                              ^
drivers/dma/altera-msgdma.c:965:9: error: 'struct dma_device' has no member named 'device_prep_dma_sg'
  dma_dev->device_prep_dma_sg = msgdma_prep_sg;
         ^

Caused by commit

  a85c6f1b2921 ("dmaengine: Add driver for Altera / Intel mSGDMA IP core")

interacting with commit

  c678fa66341c ("dmaengine: remove DMA_SG as it is dead code in kernel")

This should have been fixed up in the merge commit

  0a0ab6497093 ("Merge branch 'topic/dmatest' into next")

I have used the slave-dma tree from next-20170817 for today.

-- 
Cheers,
Stephen Rothwell