linux-kernel - Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find associated PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170822.142014.1004582480730502532.davem@davemloft.net>
Date:   Tue, 22 Aug 2017 14:20:14 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...id.au
Cc:     netdev@...r.kernel.org, benh@...nel.crashing.org, joel@....id.au,
        linux-kernel@...r.kernel.org, openbmc@...ts.ozlabs.org,
        linux-aspeed@...ts.ozlabs.org, ryan_chen@...eedtech.com
Subject: Re: [PATCH] net: ftgmac100: Fix oops in probe on failure to find
 associated PHY

From: Andrew Jeffery <andrew@...id.au>
Date: Tue, 22 Aug 2017 16:06:22 +0930

> netif_napi_del() should be paired with netif_napi_add(), however no
> such call takes place in ftgmac100_probe(). This triggers a NULL
> pointer dereference if e.g. no PHY is found by the MDIO probe:
 ...
> Signed-off-by: Andrew Jeffery <andrew@...id.au>

Applied, thanks.