linux-kernel - Re: qustion about eeh_add_virt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Aug 2017 15:44:52 +1000
From:   Russell Currey <ruscur@...sell.cc>
To:     Julia Lawall <julia.lawall@...6.fr>, benh@...nel.crashing.org,
        paulus@...ba.org, mpe@...erman.id.au,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Cc:     hch@...radead.org
Subject: Re: qustion about eeh_add_virt_device

On Sun, 2017-08-13 at 16:54 +0200, Julia Lawall wrote:
> Hello,

Hello, sorry for the delayed response.

> 
> At the suggestion of Christoph Hellwig, I am working on inlining the
> functions stored in the err_handler field of a pci_driver structure into
> the pci_driver structure itself.  A number of functions in the file
> arch/powerpc/kernel/eeh_driver.c have code like:
> 
>         if (!driver->err_handler ||
>             !driver->err_handler->error_detected) {
>                 eeh_pcid_put(dev);
>                 return NULL;
>         }
> 
> This I would just convert to:
> 
>         if (!driver->error_detected) {
>                 eeh_pcid_put(dev);
>                 return NULL;
>         }
> 
> But I am not sure what is best to do about eeh_add_virt_device, which
> contains:
> 
>                 if (driver->err_handler)
> 		        return NULL;
> 
> Should I try to find a subfield of the err_handler that is guaranteed to
> be there if anything is there?  Or could the test just be dropped, leaving
> a direct return NULL?

I believe the test can be dropped.

- Russell

> 
> thanks,
> julia