linux-kernel - Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99ef70c3-64f0-66eb-5c1a-45a034ead5d5@gmail.com>
Date:   Tue, 22 Aug 2017 20:29:52 -0400
From:   Harinath Nampally <harinath922@...il.com>
To:     Martin Kepplinger <martink@...teo.de>
Cc:     jic23@...nel.org, knaack.h@....de, lars@...afoo.de,
        pmeerw@...erw.net, gregkh@...uxfoundation.org,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        amsfield22@...il.com, linux-iio-owner@...r.kernel.org
Subject: Re: [PATCH v4] iio: accel: mma8452: improvements to handle multiple
 events

>
> If rising: use transient OR ff_mt device-dependent like before. But 
> now save it in a simple flag,
> whether transient registers are available.
Ok, is it good idea to add the flag to struct mma_chip_info like below?

   * @mma_scales:                        scale factors for converting 
register values
   *                             to m/s^2; 3 modes: 2g, 4g, 8g; 2 integers
   *                             per mode: m/s^2 and micro m/s^2
+ * @transient_supported:       flag indicating whether chip support 
transient
+ *                             event, as not all chips support 
transient event
   */
  struct mma_chip_info {
         u8 chip_id;
         const struct iio_chan_spec *channels;
         int num_channels;
         const int mma_scales[3][2];
+       bool transient_supported;
  };

>
> If falling: switch to ff_mt in any case. (fixing freefall for the 
> transient-devices) 
ok sure.

Thanks,

Hari

On 08/21/2017 04:47 AM, Martin Kepplinger wrote:
>
> If rising: use transient OR ff_mt device-dependent like before. But 
> now save it in a simple flag,
> whether transient registers are available.
>
> If falling: switch to ff_mt in any case. (fixing freefall for the 
> transient-devices)