linux-kernel - Re: [PATCH] x86/ioapic: Correctly print IRTE's index field when enabling INTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170823081638.qcxex3576qkta3lb@gmail.com>
Date:   Wed, 23 Aug 2017 10:16:39 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     raymond pang <raymondpangxd@...il.com>
Cc:     joro@...tes.org, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, linux-arch@...r.kernel.org, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/ioapic: Correctly print IRTE's index field when
 enabling INTR


* raymond pang <raymondpangxd@...il.com> wrote:

> When enabling interrupt remap, IOAPIC's RTE contains interrupt_index
> field of IRTE. And this field is composed of index and index2 member of
> struct IR_IO_APIC_route_entry. Make io_apic_print_entries() correctly
> print interrupt index field.
> 
> Signed-off-by: Raymond Pang <raymondpangxd@...il.com>
> ---
>  arch/x86/kernel/apic/io_apic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
> index 237e9c2..70e48aa 100644
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1243,7 +1243,7 @@ static void io_apic_print_entries(unsigned int
> apic, unsigned int nr_entries)
>      entry.vector, entry.irr, entry.delivery_status);
>    if (ir_entry->format)
>     printk(KERN_DEBUG "%s, remapped, I(%04X),  Z(%X)\n",
> -          buf, (ir_entry->index << 15) | ir_entry->index,
> +          buf, (ir_entry->index2 << 15) | ir_entry->index,
>            ir_entry->zero);
>    else
>     printk(KERN_DEBUG "%s, %s, D(%02X), M(%1d)\n",

Applied.

[ Note that your patch was whitespace damaged (all tabs were converted to spaces), 
  I fixed that up manually. It's a pain to keep some mailers from doing that, see
  Documentation/process/email-clients.rst for best practices. ]

Thanks,

	Ingo