linux-kernel - Re: [PATCH] rtc: ds1307: add basic support for ds1341 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda1kQkcVaChRcqg5z_b1TyWA=7FDB9aZvv_h5HAu5Fpbw@mail.gmail.com>
Date:   Wed, 23 Aug 2017 10:25:57 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Arnaud Ebalard <arno@...isbad.org>,
        David Lowe <dave-lowe@...world.com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Marek Vasut <marex@...x.de>, Tin Huynh <tnhuynh@....com>,
        linux-rtc@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Aleksander Morgado <aleksander@...ksander.es>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH] rtc: ds1307: add basic support for ds1341 chip

On Wed, Aug 23, 2017 at 7:38 AM, Nikita Yushchenko
<nikita.yoush@...entembedded.com> wrote:

> This adds support for reading and writing date/time from/to ds1314 chip.
>
> Other functionality (alarms, inout clock, output clock) is not added
> yet, because availability of that depends on chip connections.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@...entembedded.com>

Overall this looks fine.

> ---
>  drivers/rtc/Kconfig      | 10 +++++-----
>  drivers/rtc/rtc-ds1307.c | 13 +++++++++++++
>  2 files changed, 18 insertions(+), 5 deletions(-)
> ===
> DS1341/1342 chips have additional features, namely
> - alarms,
> - input clock (can be used instead of intercal oscillator for better
>   accuracy),
> - output clock ("square wave generation")

When you put all this useful information below the commit line
like this it gets lost and is not in the commit message in
git log.

Please live it into the commit blurb or even, if really useful,
as a comment in the driver itself.

With that:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij