linux-kernel - Re: [PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ6RJurzXnOzsG=b3cO0LhapE_kV2ds=U-Gpv3e84x1nw@mail.gmail.com>
Date:   Wed, 23 Aug 2017 10:29:23 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Danilo Krummrich <danilokrummrich@...develop.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux Input <linux-input@...r.kernel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v9 1/2] serio: PS/2 gpio bit banging driver for serio bus

On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich
<danilokrummrich@...develop.de> wrote:

> +static int __ps2_gpio_write(struct serio *serio, unsigned char val)
> +static int ps2_gpio_write(struct serio *serio, unsigned char val)

I never like the random use of __prefixes as they have unclear
semantics.

I would name it something concise.

Anyways, that is up to the subsystem maintainer.
>From a GPIO point of view:
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij