linux-kernel - Re: [PATCH 3/6] ALSA: pcm: Adjust 11 checks for null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hfucir8az.wl-tiwai@suse.de>
Date:   Wed, 23 Aug 2017 10:35:00 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     alsa-devel@...a-project.org, Arnd Bergmann <arnd@...db.de>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Ingo Molnar <mingo@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Sakamoto <o-takashi@...amocchi.jp>,
        Vegard Nossum <vegard.nossum@...cle.com>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/6] ALSA: pcm: Adjust 11 checks for null pointers

On Wed, 23 Aug 2017 10:25:49 +0200,
SF Markus Elfring wrote:
> 
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Wed, 23 Aug 2017 09:28:00 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The script “checkpatch.pl” pointed information out like the following.
> 
> Comparison to NULL could be written …
> 
> Thus fix the affected source code places.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Converting only these alone doesn't give any big merit.  Another patch
in the series fixed the style if ((err = xxx)), so it's fine, though.

checkpatch is no bible, after all.


thanks,

Takashi