linux-kernel - Re: [PATCH] clk: ti: make clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7632b61-a3de-e4c5-032d-e91fbb7b5f4e@ti.com>
Date:   Wed, 23 Aug 2017 12:31:22 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Bhumika Goyal <bhumirks@...il.com>, <julia.lawall@...6.fr>,
        <mturquette@...libre.com>, <sboyd@...eaurora.org>,
        <linux-omap@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clk: ti: make clk_ops const


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 22/08/17 16:11, Bhumika Goyal wrote:
> Make these const as they are only stored in the const field of a
> clk_init_data structure.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Looks fine.

Acked-by: Tero Kristo <t-kristo@...com>

> ---
>   drivers/clk/ti/adpll.c | 2 +-
>   drivers/clk/ti/apll.c  | 2 +-
>   drivers/clk/ti/fapll.c | 4 ++--
>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index 255cafb..d5c6db4 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw)
>   	return 0;
>   }
>   
> -static struct clk_ops ti_adpll_ops = {
> +static const struct clk_ops ti_adpll_ops = {
>   	.prepare = ti_adpll_prepare,
>   	.unprepare = ti_adpll_unprepare,
>   	.is_prepared = ti_adpll_is_prepared,
> diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
> index 06f486b..83b148f 100644
> --- a/drivers/clk/ti/apll.c
> +++ b/drivers/clk/ti/apll.c
> @@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw)
>   	ti_clk_ll_ops->clk_writel(v, &ad->control_reg);
>   }
>   
> -static struct clk_ops omap2_apll_ops = {
> +static const struct clk_ops omap2_apll_ops = {
>   	.enable		= &omap2_apll_enable,
>   	.disable	= &omap2_apll_disable,
>   	.is_enabled	= &omap2_apll_is_enabled,
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index 66a0d0e..071af44 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsigned long rate,
>   	return 0;
>   }
>   
> -static struct clk_ops ti_fapll_ops = {
> +static const struct clk_ops ti_fapll_ops = {
>   	.enable = ti_fapll_enable,
>   	.disable = ti_fapll_disable,
>   	.is_enabled = ti_fapll_is_enabled,
> @@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw, unsigned long rate,
>   	return 0;
>   }
>   
> -static struct clk_ops ti_fapll_synt_ops = {
> +static const struct clk_ops ti_fapll_synt_ops = {
>   	.enable = ti_fapll_synth_enable,
>   	.disable = ti_fapll_synth_disable,
>   	.is_enabled = ti_fapll_synth_is_enabled,
>