linux-kernel - Re: [PATCH] ASoC: Add a sanity check before using dai driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170823110628.xergjdexrmxyqrza@sirena.org.uk>
Date:   Wed, 23 Aug 2017 12:06:28 +0100
From:   Mark Brown <broonie@...nel.org>
To:     jeffy <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, tiwai@...e.de,
        dolinux.peng@...il.com, Jaroslav Kysela <perex@...ex.cz>,
        alsa-devel@...a-project.org, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] ASoC: Add a sanity check before using dai driver name

On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote:

> i think the original check is allowing NULL dlc dai_name to be a match...
> so we basically did:
> reject when dlc dai_name is valid, but not match the dai name

So it is, but this still looks like the wrong thing - it'll match on an
empty DAI name over an explicit match on the driver name which seems
like it's the wrong way round.

> 
> and my patch is:
> accept when dlc dai_name is invalid
> accept when match dai name
> accept when match dai driver name(only when it is valid)
> 
> so it's a "if (a && b) reject" to "if (!a || !b) accept" case..
> 
> > 
> > > +			if (dai->driver->name &&
> > > +			    !strcmp(dai->driver->name, dlc->dai_name))
> > 
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)