linux-kernel - [PATCH v2 05/10] ASoC: rockchip: Remove unnecessary function call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3ec36b8e2a98a6080bdbbc800aa190000acae104.1503484313.git.dolinux.peng@gmail.com>
Date:   Wed, 23 Aug 2017 05:20:06 -0700
From:   Peng Donglin <dolinux.peng@...il.com>
To:     heiko@...ech.de
Cc:     lgirdwood@...il.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        Peng Donglin <dolinux.peng@...il.com>
Subject: [PATCH v2 05/10] ASoC: rockchip: Remove unnecessary function call

The work of the function platform_set_drvdata is done by
devm_snd_soc_register_card.

Signed-off-by: Peng Donglin <dolinux.peng@...il.com>
---
 sound/soc/rockchip/rk3288_hdmi_analog.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/rockchip/rk3288_hdmi_analog.c b/sound/soc/rockchip/rk3288_hdmi_analog.c
index dbc53e48c52c..cf5bbd8b6ebc 100644
--- a/sound/soc/rockchip/rk3288_hdmi_analog.c
+++ b/sound/soc/rockchip/rk3288_hdmi_analog.c
@@ -266,13 +266,9 @@ static int snd_rk_mc_probe(struct platform_device *pdev)
 	ret = devm_snd_soc_register_card(&pdev->dev, card);
 	if (ret == -EPROBE_DEFER)
 		return -EPROBE_DEFER;
-	if (ret) {
+	if (ret)
 		dev_err(&pdev->dev,
 			"Soc register card failed %d\n", ret);
-		return ret;
-	}
-
-	platform_set_drvdata(pdev, card);
 
 	return ret;
 }
-- 
2.14.1