linux-kernel - Re: [PATCH] ALSA: ctxfi: make hw structures const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h7exumlrb.wl-tiwai@suse.de>
Date:   Wed, 23 Aug 2017 15:55:36 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Bhumika Goyal" <bhumirks@...il.com>
Cc:     <alsa-devel@...a-project.org>, <julia.lawall@...6.fr>,
        <perex@...ex.cz>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: ctxfi: make hw structures const

On Wed, 23 Aug 2017 14:28:42 +0200,
Bhumika Goyal wrote:
> 
> Make these const as they are only used in a copy operation.
> Done using Coccinelle:
> 
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct hw s = {...};
> 
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
> 
> @good1@
> position ref.p;
> identifier match.s,f,c;
> expression e;
> @@
> (
> e = s@p
> |
> e = s@p.f
> |
> c(...,s@p.f,...)
> |
> c(...,s@p,...)
> )
> 
> @bad depends on  !good1@
> position ref.p;
> identifier match.s;
> @@
> s@p
> 
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct hw s;
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Applied, thanks.


Takashi