linux-kernel - Re: [PATCH] phy: ralink: fix 64-bit build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <424b7b28-ff77-b7e6-3ae0-8173b7b0a411@imgtec.com>
Date:   Wed, 23 Aug 2017 14:59:14 +0100
From:   Harvey Hunt <Harvey.Hunt@...tec.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Kishon Vijay Abraham I <kishon@...com>,
        John Crispin <john@...ozen.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: ralink: fix 64-bit build warning

Hi Arnd,

On 23/08/17 14:39, Arnd Bergmann wrote:
> Casting between an 'int' and a pointer causes a warning on
> 64-bit architectures in compile-testing this driver:
> 
> drivers/phy/ralink/phy-ralink-usb.c: In function 'ralink_usb_phy_probe':
> drivers/phy/ralink/phy-ralink-usb.c:195:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> 
> This changes the code to cast to uintptr_t instead. This is
> guaranteed to do what we want on all architectures and avoids
> the warning.
> 
> Fixes: 2411a736ff09 ("phy: ralink-usb: add driver for Mediatek/Ralink")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/phy/ralink/phy-ralink-usb.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
[...]

Thanks for fixing this - it was on my TODO list.

Tested-by Harvey Hunt <harvey.hunt@...tec.com>
Reviewed-by Harvey Hunt <harvey.hunt@...tec.com>

Thanks,

Harvey