linux-kernel - Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170823143113.nt6p4hqeglqmynmg@flea.home>
Date:   Wed, 23 Aug 2017 16:31:13 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Icenowy Zheng <icenowy@...c.io>
Cc:     Chen-Yu Tsai <wens@...e.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2
 Berry

On Wed, Aug 23, 2017 at 01:46:50PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard <maxime.ripard@...e-electrons.com> 写到:
> >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote:
> >> +&reg_vcc5v0 {
> >> +	gpio = <&pio 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */
> >> +	enable-active-high;
> >> +};
> >
> >Same thing here, you're not using that regulator anywhere. You don't
> >even use any of the regulators in sunxi-common-regulators.
> 
> Maybe I should drop the regulator now, and re-introduce it when adding USB/SATA?

If that's what it's used for, then yes, please.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)